Skip to content

Conversation

ryanwilson
Copy link
Member

Description

This isn't clear in the sample UI why this is happening, and ends up using more tokens than necessary.

Related Issues

Internal bug report.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

This isn't clear in the sample UI why this is happening, and ends up using more tokens than necessary.
@SelaseKay SelaseKay changed the title Remove generateContent call from count tokens page chore: remove generateContent call from count tokens page Aug 12, 2025
@ryanwilson ryanwilson requested a review from cynthiajoan August 13, 2025 12:35
@cynthiajoan cynthiajoan changed the title chore: remove generateContent call from count tokens page chore(firebaseai): remove generateContent call from count tokens page Aug 13, 2025
@SelaseKay SelaseKay merged commit db913d8 into main Aug 14, 2025
15 of 16 checks passed
@SelaseKay SelaseKay deleted the fix/sample-token-count branch August 14, 2025 08:11
gspencergoog pushed a commit to gspencergoog/flutterfire that referenced this pull request Aug 19, 2025
This isn't clear in the sample UI why this is happening, and ends up using more tokens than necessary.
sybrands-place pushed a commit to sybrands-place/flutterfire that referenced this pull request Aug 27, 2025
* main: (31 commits)
  making sure vertex instance will differentiate with location (firebase#17664)
  fix(firebaseai): Added token details parsing for Dev API (firebase#17609)
  feat(firebaseai): add thinking feature (firebase#17652)
  feat(firebaseai): Add app check limited use token (firebase#17645)
  fix(firebaseai): remove candidateCount from LiveGenerationConfig since the connection fails silently when it is set (firebase#17647)
  fix(firebaseai): Export `UnknownPart` (firebase#17655)
  fix(firebase_ai): Add `GroundingMetadata` parsing for Developer API (firebase#17657)
  fix(app_check, iOS): correctly parse `forceRefresh` argument using `boolValue` (firebase#17627)
  feat(firebaseai): imagen editing (firebase#17556)
  feat(firebaseai): add responseJsonSchema to GenerationConfig (firebase#17564)
  chore(firebaseai): fix error message test failure (firebase#17644)
  ci(apple): fix CI runners with explicit Xcode version (firebase#17634)
  chore(firebaseai): Minor fix for error message wording (firebase#17639)
  chore: fix warnings after latest flutter version (firebase#17640)
  Update CHANGELOG.md, put live api entry back for the official announcment (firebase#17635)
  fix(ci): ignore .gradle files in license check (firebase#17625)
  Remove `generateContent` call from count tokens page (firebase#17613)
  Update CHANGELOG.md (firebase#17621)
  Update CONTRIBUTING.md to add API change rule (firebase#17619)
  chore(release): publish packages (firebase#17618)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants